Drop build_reduction_data and refactor the reduce module - Githubissues

Ouranosinc / xscen

A climate change scenario-building analysis framework.

https://xscen.readthedocs.io/

Apache License 2.0

13 stars 2 forks source link

Drop build_reduction_data and refactor the reduce module #386

Closed RondeauG closed 2 months ago

RondeauG commented 2 months ago

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[x] (If applicable) Documentation has been added / updated (for bug fixes / features).
[x] (If applicable) Tests have been added.
[x] This PR does not seem to break the templates.
[x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

xs.reduce_ensemble will now call xclim.ensembles.create_ensemble and xclim.ensembles.make_critera if required.

Does this PR introduce a breaking change?

The xscen.reduce module has been abandoned.
- build_reduction_data has been made redundant by xclim.ensembles.make_critera and will be removed in a future release.
- xscen.reduce.reduce_ensemble has been moved to xscen.ensembles.reduce_ensemble, as a module was no longer necessary.

Other information:

RondeauG commented 2 months ago

@aulemahal @juliettelavoie I put this as a draft, because this is what I'm proposing:

You review the changes as they are here.
Once we're happy with them, I move reduce_ensemble to ensembles.py and we fully abandon reduce.py. --> This would mess up GitHub's track changes, which is why I'd like to have the first step.
Alongside 2, I fix the documentation and add tests.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB