Fix `xr_combine_kwargs` in extract_dataset - Githubissues

Ouranosinc / xscen

A climate change scenario-building analysis framework.

https://xscen.readthedocs.io/

Apache License 2.0

13 stars 2 forks source link

Fix `xr_combine_kwargs` in extract_dataset #402

Closed aulemahal closed 1 month ago

aulemahal commented 1 month ago

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[ ] (If applicable) Documentation has been added / updated (for bug fixes / features).
[ ] (If applicable) Tests have been added.
[x] This PR does not seem to break the templates.
[x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

In #398, I introduced a new way of setting defaults for xr_combine_kwargs in extract_dataset, but I missed one use of the argument, which make extract_dataset fail when nothing is given to the argument.

Does this PR introduce a breaking change?

No.

Other information:

Seen by Dominic et Oumou.