update_attr bug

[juliettelavoie]

Setup Information

• xscen version: 0.9
• Python version: 3.11
• Operating System: linux env xscen-0.9

Description

compute_delta casse sur update_attr

  File "/home/jlavoie/Projets/xscen/xscen/config.py", line 224, in _wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/jlavoie/Projets/xscen/xscen/aggregate.py", line 646, in compute_deltas
    update_attr(
  File "/home/jlavoie/Projets/xscen/xscen/utils.py", line 145, in update_attr
    f"attr{i}": dso.attrs.get(key, dso.attrs.get(attr, "")).strip(" .")
                ^^^^^^^^^
AttributeError: 'str' object has no attribute 'attrs'

Steps To Reproduce

ds= xr.open_zarr('/PATH/xscen-template/test1/climatology/CMIP6_ScenarioMIP_CMCC_CMCC-ESM2_ssp245_r1i1p1f1_global_MS_climatology.zarr')
xs.compute_deltas(ds, reference_horizon='1951-1980')

Additional context

Je pense que associer un dict à une liste dans laquelle on est en train d'iterate, ça bug.

        others = {
            f"attr{i}": dso.attrs.get(attr, "").strip(" .")
            for i, dso in enumerate(others, 1)
        }

Contribution

• [x] I would be willing/able to open a Pull Request to address this bug.