OurchiveIO / ourchive

An easily installable fiction, audio, and image archive package.
GNU General Public License v3.0
8 stars 6 forks source link

Users created with wrong icon url #133

Closed bellisk closed 3 months ago

bellisk commented 5 months ago

Describe the bug I created a new user via registration. The new user's icon url was set to http://127.0.0.1:8000/static/icon-default.png, but should have been https://example.org/static/icon-default.png. (127.0.0.1:8000 is the sample value for OURCHIVE_ROOT_URL, but I had changed this to example.org on initial setup.)

To Reproduce

  1. Deploy Ourchive to VPS hosting as described in https://docs.getourchive.io/admin-getting-started/
  2. In .env, update OURCHIVE_ROOT_URL to (e.g.) example.org and OURCHIVE_SERVER_IP to the actual server IP
  3. Create a new user via direct registration, not via requesting an invite (I haven't tested that path)
  4. On the user page, instead of an icon, is a broken-image icon
  5. Right-click on the image and select "Open image in new tab". The icon url is http://127.0.0.1:8000/static/icon-default.png

Expected behavior The new user's icon should use the correct url, e.g. https://example.org/static/icon-default.png.

Screenshots Screenshot 2024-04-19 at 22-44-52 User - test_user2

Hosting Digital Ocean droplet running Ubuntu 22.04.

c-e-p commented 5 months ago

Probably an issue with static file handling. Will be fixed with next release.

c-e-p commented 3 months ago

Was indeed an issue with static file handling. Validated with new signup in dev.