OutCast3k / coinbin

Javascript Bitcoin Wallet. Supports Multisig, Stealth, HD, SegWit, Bech32, Time Locked Addresses, RBF and more!
https://coinb.in/
MIT License
906 stars 621 forks source link

unable to turn off RBF for Timelocked txns #193

Closed yakitorifoodie closed 4 years ago

yakitorifoodie commented 5 years ago

unable to turn off RBF. Please fix it.

ghost commented 4 years ago

@panagiotos RBF is turned off by default. I was able to make transactions with and without RBF.
If you are still having an issue, could you explain with more detail?

yakitorifoodie commented 4 years ago

@Wowee0

RBF automatically turned off for normal txns but not for timelocked txn.

yakitorifoodie commented 4 years ago

i checked a timelocked txn by turning off and on RBF at https://live.blockcypher.com/btc/decodetx/ and it always shows "opt_in_rbf": true,.

ghost commented 4 years ago

@lizz-y Here's a timelocked transaction made by coinbin on BTC testnet, tx#7d89b9821776ad1fef7aeb508209b470a5219591714bb59dfb15e43846ce1757. Timelock script is "03c32818b1752103a51cec1cfe9844c9c3e9b536bea8edb22c1fef0af1b55b19dc197170a9e58567ac". The TX does not have RBF turned on.

Could you provide more information, and a testnet example, created by coinbin.

[edit] ok, I think I see what you are referring to, the transaction spending FROM a timelocked address are showing up as RBF=true, even if the RBF checkbox is unchecked. RBF is enabled when the sequence number is lower than 0xfffffffe.

ghost commented 4 years ago

Documentation:

yakitorifoodie commented 4 years ago

Thank you very much for addressing the issue.