OutSystems / cordova-outsystems-secure-sqlite-bundle

Cordova meta-plugin that bundles requirements for secure SQLite device storage and initialization code for easy usage within OutSystems Platform native mobile apps
1 stars 9 forks source link

RNMT-3824 Errors in the first reads/writes of a Key Store when multiple initializations run simultaneously #11

Closed usernuno closed 4 years ago

usernuno commented 4 years ago

Description

Reverts the previous fix. Raises the used version of the Key Store Plugin.

Context

Fixes https://outsystemsrd.atlassian.net/browse/RNMT-3824

This commit raises the used version of the Key Store Plugin. It mostly does not affect this plugin, but we should raise this to the latest version available.

Type of changes

Components affected

Tests

Manual tests were performed

Screenshots (if appropriate)

Checklist

cmfsotelo commented 4 years ago

Comming late to the party, but, can you give more context on the why of the revert commit?

usernuno commented 4 years ago

Comming late to the party, but, can you give more context on the why of the revert commit?

We reverted the fix in this plugin and the Key Store Plugin because we don't want the experience to be the current one. If possible we intend to remove the lock screen popup during the app (it only appears in Android 10 due to the new used intent).

The fix was essentially enforcing that the lock screen was actually correctly authenticated. Since we intend to remove the lock screen, that version was not released. To release a new one we needed to revert the change.

There is already an issue in the backlog to tackle the experience.