Outblock / FRW-Extension

Flow Reference Wallet - Chrome Extension Client
1 stars 4 forks source link

[FEATURE] Improve code formatting and linting #144

Closed tombeckenham closed 2 days ago

tombeckenham commented 1 week ago

Issue to be solved

There is currently no unified approach to code formatting and linting. This makes it hard to collaborate on the code base. Saving a file on one machine may completely change the formatting of the whole file. This makes it difficult to see which parts of the code properly were altered when reviewing PRs. Although the project has a prettier and eslint setting, there is no editor config which forces the format on save option. That's produced code that is not uniformly formatted - some lines are formatted one way, and other lines in the same file are formatted another

Suggest A Solution

  1. Tighten up the prettier and eslint settings. They are currently too loose
  2. Introduce an editor config file that forces format on save
  3. Add a GitHub action that prevents code from being checked in or merged if it does not follow the formatting rules