OutdoorRD / trails-viz

1 stars 2 forks source link

Dashboard not aggregating data across project if any data points are NAs #191

Open sgwinder opened 11 months ago

sgwinder commented 11 months ago

Related to Issue #110 and Issue #127.

When the dashboard tries to calculate the totals across the entire AOI it is dropping any variables with NAs. This is good behavior for things like onsite data. But much murkier in cases where we're simply missing mobile data from 1-2 polygons (as id'd here), where it seems reasonable to have the Gravy totals displayed.

But it's tricky to make a generalizable rule for this, as Spencer's questions lay out:

More difficult, perhaps, is agreeing on specifics like: whether to do that everywhere/always, or only for certain projects, or only for certain time series with below a threshold number/% or NA values, or...

Our best solution may be to stop having the dashboard do this on the fly, and instead move some of the code that does these aggregations (and calculates monthly averages) into another repo like viz-model.