Closed incanus closed 12 years ago
I really like what you're doing here, thanks for all your efforts!
I'd like to apply all of them to this fork. I'm not sure if not some of them break our apps but I'll find that out. #35 might actually break something I'm currently working on, but that's also easy to fix and if you're happy with it I am sure I will be happy with it as well... :)
Again, thanks for all the work you're putting into this and for sharing all the patches!
(Especially, I like the patches that end with "like MapKit"... :)
Ok. I'll still try to break it up a bit so it's easier to go through, if it doesn't drive me crazy ;-)
So we've just done a release over on the MapBox iOS SDK and I've got a number of improvements to send up to you. At the very least, it's many pull requests, so I wanted to run them by you upfront and get a sense of whether you want some or all. I will try to combine the ones you want logically by feature area so they are a bit easier to review.
Features I'm guessing you'll want
backgroundImage
, a map view gets anRMTileLoadingView
(internal variable like the scroll view) that has a grid background image. The difference is that it moves with the map panning, so it provides some context for before tile images load. When zooming, the grid lines disappear, just like MapKit, then reappear when zooming is complete, and the effect is pretty nice overall.BOOL
and added option to auto-remove it after ten seconds if still visible more like MapKit.BOOL
arguments to the before/after map pan/zoom delegate callbacks to let the delegate know if this was related to a user action (touch) or not (centering on user location, programmatic zoom, etc.) See this method for example.Bug fixes & tweaks I'm guessing you'll want
RMMapViewDelegate
now exposed as anIBOutlet
.BOOL
) and user location annotations are below everything else.Features that I'm not sure if you will want or not
missingTilesDepth = 1
. You can see the diff at a90ff6c7f9c4dcd042d02562502a90cb7c230e92Bug fixes & tweakies that I'm not sure if you will want or not
RMMapDecelerationFast
like MapKit.RMMapView
protocol adoptions moved into private API so they don't show up in the new docs.