No planets/ship log entries are added

[DomiStyle]

What Happened?

The main menu will get changed and add the new banner to the DLC area but ingame everything seems to be in a vanilla state, no ship entries or new planets are generated.

Full disclaimer, I'm running this game on Linux with Proton. The issue might be caused by that.

What was supposed to happen?

Planets should be changed/added and ship log entries should appear.

Platform

Steam

Mods

* New Horizons
* Vanilla Fix
* Any New Horizons Mod

Logs

Unfortunately there are no exceptions with any mod except The Vision (issue for that is here)

Here is a complete verbose log from start to finish with Outer Wilds Galaxy enabled:

https://gist.github.com/DomiStyle/744f307dc52f67883e9d3d3fa1ba26df

Just for completeness, here's the verbose logs with The Vision enabled:

https://gist.github.com/DomiStyle/cc291d5f935e64557825fcd8306a6a2c

[mrwallace888]

For the record, you did check the ship computer? You've got the map and rumors, but if you press the rumor mode button on the map, you bring up an interstellar menu which is where you fast travel between systems.

[DomiStyle]

Good point, either I can't find the interstellar menu or there is none. This is what the ship computer looks like with New Horizons + Real Solar System enabled on a fresh save:

Pressing C just toggles between those 2 views.

[mrwallace888]

Is there a "MODS" section in the pause menu? Do your mods show up?

What about non-NH mods? Do those work at all?

[DomiStyle]

Yes, every mod so far is working except New Horizons.

The mods section is there, the debug menu for New Horizons is there, the main menu gets changed. Just ingame everything looks vanilla.

[DomiStyle]

Found the cause.

https://github.com/Outer-Wilds-New-Horizons/new-horizons/blob/main/NewHorizons/Main.cs#L489 https://github.com/Outer-Wilds-New-Horizons/new-horizons/blob/main/NewHorizons/Main.cs#L524

The ? at the end of the search string causes Mono (in this case) to not find any files, preventing any systems and planets from being loaded. No idea why, it works in both Mono on Linux and Mono in Wine when testing normally. Maybe something is bugged in the specific version of Mono Outer Wilds uses.

This was added 4 months ago in this commit: https://github.com/Outer-Wilds-New-Horizons/new-horizons/commit/175b8c1f8017fff2e668206a3a04b2acf84486a5

@Bwc9876 Is the JSONC support used anywhere or can I just remove the ? in a PR? If not I can also try both variants so nothing breaks for current mods.

[Bwc9876]

Yes, some of our users use jsonc to allow for comments, we'll just have to change how we load them, thank you for figuring it out!

[DomiStyle]

Thanks, will put in a PR later today which looks for both then.

[DomiStyle]

Closing this since it's fixed by the PR.