Outer-Wilds-New-Horizons / new-horizons

A tool for modifying or creating new planets, dialogue, ship logs, and more for Outer Wilds.
https://nh.outerwildsmods.com/
MIT License
42 stars 18 forks source link

XmlException with credits #565

Closed hearth1an closed 1 year ago

hearth1an commented 1 year ago

What Happened?

No credits roll after the custom death text. Trhowing XmlException, still skippable.

credits on addon-manifest

"credits": [ "hearth1an & xen#Mod Authors.", "Thank you for playing Christmas Story!" ],

and credits volume: "Volumes": { "creditsVolume": [ { "deathType": "bigBang", "creditsType": "fast", "gameOverText": "ENDING_TEXT", "radius": 10, "isRelativeToParent": true, "position": { "y": -100 }, "rename": "Ending_Trigger" } ] },

What was supposed to happen?

Good looking credits ::)

Platform

None

Mods

No response

Logs

XmlException: An error occurred while parsing EntityName. Line 2, position 12.
Stacktrace: System.Xml.XmlTextReaderImpl.Throw (System.Exception e) (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlTextReaderImpl.Throw (System.String res, System.String arg) (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlTextReaderImpl.Throw (System.String res) (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlTextReaderImpl.ParseEntityName () (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlTextReaderImpl.ParseEntityReference () (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlTextReaderImpl.Read () (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlLoader.LoadNode (System.Boolean skipOverWhitespace) (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlLoader.LoadDocSequence (System.Xml.XmlDocument parentDoc) (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlLoader.Load (System.Xml.XmlDocument doc, System.Xml.XmlReader reader, System.Boolean preserveWhitespace) (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlDocument.Load (System.Xml.XmlReader reader) (at <bba3a54eadce4176b12f94bef4e21a75>:0)
System.Xml.XmlDocument.LoadXml (System.String xml) (at <bba3a54eadce4176b12f94bef4e21a75>:0)
NewHorizons.Handlers.CreditsHandler.StringToNodes (System.Xml.XmlDocument docContext, System.String text) (at <af3dbe99d59e4e0eacbeb75214ec8b8d>:0)
NewHorizons.Handlers.CreditsHandler.CreateScrollCreditsFromList (System.Xml.XmlDocument doc, System.String title, System.String[] entries) (at <af3dbe99d59e4e0eacbeb75214ec8b8d>:0)
NewHorizons.Handlers.CreditsHandler.AddCreditsSection (System.String sectionName, System.String[] entries, System.Xml.XmlDocument& xml) (at <af3dbe99d59e4e0eacbeb75214ec8b8d>:0)
NewHorizons.Handlers.CreditsHandler.AddCredits (Credits credits) (at <af3dbe99d59e4e0eacbeb75214ec8b8d>:0)
NewHorizons.Patches.CreditsScenePatches.CreditsPatches.Credits_Start (Credits __instance) (at <af3dbe99d59e4e0eacbeb75214ec8b8d>:0)
(wrapper dynamic-method) Credits.DMD<Credits::Start>(Credits)
Bwc9876 commented 1 year ago

This could be a result of the ampersand in your credits as it's a reserved character, try changing & to &amp;

hearth1an commented 1 year ago

Yes it works now, thanks!