search

Outer-Wilds-New-Horizons / new-horizons

A tool for modifying or creating new planets, dialogue, ship logs, and more for Outer Wilds.
https://nh.outerwildsmods.com/
MIT License
42 stars 18 forks source link

Solar Flare colors broken #616

Closed GameWyrm closed 1 year ago

GameWyrm commented 1 year ago

What Happened?

On a custom sun, the solar flares use the default orange even though my sun is supposed to be blue. Sun schema: { "$schema": "https://raw.githubusercontent.com/Outer-Wilds-New-Horizons/new-horizons/main/NewHorizons/Schemas/body_schema.json", "name": "Jam Sun", "starSystem": "GameWyrm.JamSystem", "Base": { "centerOfSolarSystem": true, "gravityFallOff": "inverseSquared", "surfaceSize": 2000, "surfaceGravity": 500 }, "canShowOnTitle": false, "Star": { "hasAtmosphere": true, "lightTint": { "r": 220, "g": 220, "b": 255, "a": 255 }, "tint": { "r": 150, "g": 150, "b": 255, "a": 255 }, "endTint": { "r": 0, "g": 0, "b": 255, "a": 255 } } } image

What was supposed to happen?

Flares should roughly be the color of the sun's surface

Platform

Steam

Mods

OWML
New Horizons
Vanilla Fix
Menu Framework
Common Camera Utility
Custom Ship Log Modes
Cheat and Debug Menu
Unity Explorer

Logs

No response

misternebula commented 1 year ago

the reason for this is that SunController is using it's _solarFlareTint gradient to keep changing the tint/color back to the vanilla sun color

xen-42 commented 1 year ago

@misternebula That's not true, NH stars do not use SunController. Also, the solar flare colour isn't actually the vanilla sun colour, you can see it's slightly tinted.

xen-42 commented 1 year ago

The issue was actually that we were trying to change the colour of existing SolarFlareControllers when creating the star, however they were being made later from prefabs on the SolarFlareEmitter. So we had to change those instead.