eslint chores

[tylim88]

1. remove redundant eslint config
2. move package.json eslint config to eslintrc (eslint ignore config in package.json if eslintrc exist)

effect:

from this

to this

[tylim88]

wait, few more changes

[HenryHengZJ]

@tylim88 there are some issues with yarn build, that means previously it wasn't properly configured. I pushed a fix here: https://github.com/Outerbridgeio/Outerbridge/commit/179389b6dc57bb78527ab2b94daf790695d899f8, if you can pull that into your local branch

[tylim88]

accidentally pushed prettified contractDialog, code logic remain unchanged, just formatted

[tylim88]

@tylim88 there are some issues with yarn build, that means previously it wasn't properly configured. I pushed a fix here: 179389b, if you can pull that into your local branch

to this branch? or my master?

[HenryHengZJ]

to this branch. Do you not have problem when running yarn build on this branch? I had some ui problems there

[tylim88]

to this branch. Do you not have problem when running yarn build on this branch? I had some ui problems there

yarn build did cause issue before this commit https://github.com/Outerbridgeio/Outerbridge/commit/179389b6dc57bb78527ab2b94daf790695d899f8, and this commit fix it

but now commit https://github.com/Outerbridgeio/Outerbridge/pull/86/commits/f31c727a9cd1811bd9f5d9edae23688fecb1ce0f causing some eslint prettier issue and I am fixing it

[tylim88]

commit https://github.com/Outerbridgeio/Outerbridge/commit/179389b6dc57bb78527ab2b94daf790695d899f8 pulled to this branch

[tylim88]

yarn build passed and website seem fine

in future we can add

1. commit hooks (run yarn build, tests, formatting and linter before commit) <- may degrade dev experience if too much commands(also it is skippable), so it is better to run CI
2. CI
3. tests

so we don't need to manually test every commit

[HenryHengZJ]

I'll see if I can add TravisCI in coming days for basic yarn build cus there isnt any test yet. But definitely need unit test and e2e test in future

[HenryHengZJ]

Commit hooks is better to be added after we have prettier eslint configured for all 3 packages

[HenryHengZJ]

@tylim88 not sure if you have this but My VSCode is complaining about babel To solve this I had to add https://stackoverflow.com/a/72625130 requireConfigFile: false

[tylim88]

@tylim88 not sure if you have this but My VSCode is complaining about babel To solve this I had to add https://stackoverflow.com/a/72625130 requireConfigFile: false

I don't have this issue but I can add it