search

Outerbridgeio / Outerbridge

Outerbridge is a low code/no code workflow automation application, focusing on integrating both on-chain and off-chain applications.
https://outerbridge.io
Apache License 2.0
170 stars 58 forks source link

Chores/eslint prettier for component and server #98

Closed tylim88 closed 2 years ago

tylim88 commented 2 years ago
  1. removing all lock file before bootstrap seem to ensure symlink
  2. also removed @type/nodes
  3. refactor gitignore, eslint, prettier, common dev dependencies to root
  4. resolve any dependency that is different from the hoisted

run yarn bootstrap first because eslint is updated to v8, after that you can try run yarn lint or yarn lint-fix in root to see the effect

see commit messages for more details

tylim88 commented 2 years ago

it is also possible to refactor tsconfig, but I will do that after i complete the ui conversion

tylim88 commented 2 years ago

the commit https://github.com/Outerbridgeio/Outerbridge/pull/98/commits/6e4fc53e916a7f817cc2d6bd2dc6dd112cdb9bd1 makes prettier removes all semi colon in most cases when you run lint-fix

prettier will insert semicolon automatically if the statement start with [ to avoid mistake https://prettier.io/docs/en/rationale.html#semicolons

tylim88 commented 2 years ago
  1. now there is only one gitignore, prettierignore, eslint config, prettier config, all in the root folder
  2. commit hook added (lint and format)
  3. formatted all files at https://github.com/Outerbridgeio/Outerbridge/pull/98/commits/a17b7bf44cf611604459596077a14f648bca2c25
tylim88 commented 2 years ago

changes that need manual test https://github.com/Outerbridgeio/Outerbridge/pull/98/commits/16f3393bc844023ed08ad3ac5f08fc3ba7dfe765 https://github.com/Outerbridgeio/Outerbridge/pull/98/commits/2ec782d93d9f6c8f31d22e933abc9d8b158e32f9 https://github.com/Outerbridgeio/Outerbridge/pull/98/commits/83f848ccf42d24026f067b08a972c13cb2d613ec https://github.com/Outerbridgeio/Outerbridge/pull/98/commits/d1978c72c038024eaa1e097752378d84c34fb5e3 https://github.com/Outerbridgeio/Outerbridge/pull/98/commits/a973b230e95f93cd5a308160d7e1f811c8207a6b

tylim88 commented 2 years ago

website seem fine, but I need your help to test files from these commits @HenryHengZJ

changes that need manual test 16f3393 2ec782d 83f848c d1978c7 a973b23

tylim88 commented 2 years ago

nothing to add now

one weird thing is, react-scripts will fail the compilation in CI if it has no-console eslint warning

nodejs 14 is killing me

tylim88 commented 2 years ago

basically that is it

end result: in nodejs 16, you should not see any warning when you run bootstrap, build, lint, start and dev in nodejs 14 however, you will see warnings when you run lint, eslint think typescript type is some kind of variable