Outfitio / Outfit-Fonts

The most on-brand typeface
https://outfit.io/font
SIL Open Font License 1.1
258 stars 13 forks source link

Suggest to loosen the dependency on sh #19

Closed Agnes-U closed 1 year ago

Agnes-U commented 1 year ago

Hi, your project Outfit-Fonts(commit id: dcc810855e997afd5de73215566aebbe0f13506d) requires "sh==1.14.2" in its dependency. After analyzing the source code, we found that the following versions of sh can also be suitable, i.e., sh 1.14.0, 1.14.1, since all functions that you directly (1 APIs: sh.git) or indirectly (propagate to -1 sh's internal APIs and 0 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on sh from "sh==1.14.2" to "sh>=1.14.0,<=1.14.2". This will improve the applicability of Outfit-Fonts and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on sh?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?