ablaom commented 2 years ago

I need this because Flux 0.12 uses an old version of AbstractTrees.jl.

ablaom commented 2 years ago

This is failing locally for me, but the source of the current fail is unrelated; see #6 .

codecov[bot] commented 2 years ago

Codecov Report

Merging #7 (0288073) into master (05d934e) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         5    -2     
  Lines           81        79    -2     
=========================================
- Hits            81        79    -2

Impacted Files	Coverage Δ
src/models/ae.jl	`100.00% <ø> (ø)`
src/models/esad.jl	`100.00% <ø> (ø)`
src/models/dsad.jl	`100.00% <100.00%> (ø)`
src/templates/templates.jl
src/OutlierDetectionNetworks.jl

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

davnn commented 2 years ago

Hi! Thanks for the update and notice that the tests are failing. The tests were failing because we disallowed non-categorical labels in https://github.com/OutlierDetectionJL/OutlierDetectionInterface.jl/commit/bca9a5290fc44a2eba3ea93bf547c89f73d97494, but the tests still provided non-categorical labels, fixed in https://github.com/OutlierDetectionJL/OutlierDetectionTest.jl/releases/tag/v0.2.1.

ablaom commented 2 years ago

@davnn Thanks for the very prompt response.

OutlierDetectionJL / OutlierDetectionNetworks.jl

Extend Flux compatibility to include 0.13 #7

Codecov Report