OutlierVentures / BuyCoPoc

BuyCo.io Proof of Concept on an Ethereum blockchain
Apache License 2.0
0 stars 1 forks source link

Seller signup form: Error on ovMessage in console #13

Closed AronVanAmmers closed 8 years ago

AronVanAmmers commented 8 years ago

On opening https://selfsigned.blockstars.io:4124/seller/signup I see the error below in the console. The form seems to work fine though. After Submit the message "You signed up as seller" appears fine (suggesting that the ovMessage seems to work).

Error: [$compile:nonassign] Expression 'undefined' used with directive 'ovMessage' is non-assignable!
http://errors.angularjs.org/1.4.9/$compile/nonassign?p0=undefined&p1=ovMessage
    at angular.js:68
    at parentSet (angular.js:9092)
    at parentValueWatch (angular.js:9105)
    at Object.regularInterceptedExpression (angular.js:14646)
    at Scope.$digest (angular.js:16087)
    at Scope.$apply (angular.js:16359)
    at done (angular.js:10791)
    at completeRequest (angular.js:10989)
    at XMLHttpRequest.requestLoaded (angular.js:10930)
bartvanderwal commented 8 years ago

Strange. I can't reproduce that on my machine. Console shows no errors. Neither in first time signup, as in edit screen for seller. @AronVanAmmers , can you add a screenshot?

AronVanAmmers commented 8 years ago

I can reproduce it on current test version https://blockstars.io:4124/ by simply opening https://blockstars.io:4124/seller/signup:

2016-01-28 18_09_18-developer tools - https___blockstars io_4124_seller_signup

bartvanderwal commented 8 years ago

Strange, I changed that console.log message at the top a while ago, so I'm wondering if this isn't a case of a hard refresh (ctrl+F5) or local recompile of .ts would fix. But it's probably a merge issue. I'll check it.

bartvanderwal commented 8 years ago

Fixed. To do this I just commented a scope variable in the message directive I had added to try and get some validation messages in the seller-proposals screen when there's an invalid filter specified. I forgot to change the seller-screen which I had refactored to use the same directive for it's message box. But the numerical fields are marked red now, when you type text in them, so that will probably suffice for now.