Bower packages: "moment" and "momentjs". One obsolete?

OutlierVentures / BuyCoPoc

BuyCo.io Proof of Concept on an Ethereum blockchain

Apache License 2.0

0 stars 1 forks source link

Bower packages: "moment" and "momentjs". One obsolete? #49

Open AronVanAmmers opened 8 years ago

AronVanAmmers commented 8 years ago

I just installed angular-timer, which requires momentjs. We already had moment which is required by angular-moment. moment and momentjs seem to be 2 instances of the same thing.

AronVanAmmers commented 8 years ago

Apparently the devs of angular-timer realized this and corrected to moment, though the version installed through bower still refers to momentjs.

In any case it doesn't seem to cause any conflicts on our side.

bartvanderwal commented 8 years ago

Okay!

Yeah they are the same thing, @AronVanAmmers I agree. I see angular-timer's package.json is uptodate but bower.json is not.

They indeed updated already, but forgot to bump the version number which apparently is a requirement for update of a bower package. So I suggested to do that.

I assume the small version difference won't be a problem. bower_components/moment/ (v2.10.6) bower_components/momentjs/ (v2.9.0)