search

OutpostUniverse / NetFixServer

0 stars 0 forks source link

Refactor find game info functions #33

Closed Brett208 closed 4 years ago

Brett208 commented 4 years ago

Closes #32

I am open if there is a better way to accomplish the refactor

Brett208 commented 4 years ago

Changing GameData into a vector will cause a lot of unrelated changes. Maybe we should table this branch until a separate GameData commit is completed and see if that presents a more agreeable solution all around.

I tried cherry picking the other two commits into a separate branch. @DanRStevens if it doesn't look like I cherry picked right, feel free to delete that branch and do it yourself. It is still confusing for me how it works.

DanRStevens commented 4 years ago

Ok, sounds like a plan.

Brett208 commented 4 years ago

I'm going to close this PR and delete the remote branch since the implementation wasn't agreeable to all parties. The first 2 commits were already cherry picked into master. I'll have a copy on my local machine if I want to reference in the near future.