search

OutpostUniverse / OP2Internal

Class definitions compatible with the in-memory format used by Outpost 2
0 stars 0 forks source link

Add GUID include to NetTransportLayer header #24

Closed Brett208 closed 5 years ago

Brett208 commented 5 years ago

Closes #20

DanRStevens commented 5 years ago

Just noticed the following in Packet.h in the same folder:

// Bring in definitions of structs: GUID, sockaddr_in
#include <winsock2.h>

Not sure if you want to adjust the include or not based on this. Probably not. We definitely should be including something that defines GUID though, otherwise the NetTransportLayer.h header isn't standalone.

Brett208 commented 5 years ago

I'm not sure what your comment is getting at? Are you suggesting that we should use the winsock header in NetTransportLayer or that we should add rpc header in Packet.h?

Thanks, Brett

DanRStevens commented 5 years ago

I'm not certain. I was deferring to you. I think we should add one of the two headers. As per the online documentation, rpc.h is the preferred header for GUID.

There will be a difference in the include in Packet.h, but Packet.h also needs sockaddr_in, and it seems winsock2.h includes both GUID and sockaddr_in, so it's also probably fine.

I think we should just merge.