search

OutpostUniverse / OP2Utility

C++ library for working with Outpost 2 related files and tasks.
MIT License
4 stars 0 forks source link

Remove base type on `VolPadding` enum #186

Closed DanRStevens closed 5 years ago

DanRStevens commented 6 years ago

This enum is a two valued bit flag. It probably doesn't make sense to explicitly declare the base type as a 32-bit quantity.

DanRStevens commented 5 years ago

Indeed, I started that trend thinking it was a good idea, but also with no research behind it. I think it would make more sense for non-bitfield enums, where the defined size is actually correct. More so though, it seems most useful for opaque enums.