search

OutpostUniverse / OP2Utility

C++ library for working with Outpost 2 related files and tasks.
MIT License
4 stars 0 forks source link

Switch to vcpkg for gtest #248

Closed Brett208 closed 4 years ago

Brett208 commented 5 years ago

Branch does not work on my computer in debug mode. Took a stab at updating appveyor but not tested.

DanRStevens commented 5 years ago

I wanted to bump this PR as the Google Test NuGet package was recently update. Additionally stdcpp17 has been enabled for the LanguageStandard setting. That covers some of the changes done in this PR.

Not addressed, is the use of Google Mock.

I would really like to avoid burdening new developers with complex setup requirements to build and test the project. As vcpkg isn't as automated as NuGet for local builds, perhaps we could add a feature detect for Google Mock, and use that to replace the #ifndef _WIN32 platform detect. I believe we could do this using '__has_include', or perhaps Google Mock itself defines a macro that can be tested.

With such a detect in place, I'd feel more comfortable about using vcpkg on AppVeyor to install a Google Mock dependency.

Brett208 commented 4 years ago

Just adding the gmock nuget package that is officialy released by Google allows us easy, standardized access to gmock on MSVC.

With this revelation, I see no reason to continue experimenting with vcpkg at this time and am closing this branch.