search

OutpostUniverse / OP2Utility

C++ library for working with Outpost 2 related files and tasks.
MIT License
4 stars 0 forks source link

Fix GetDirectory #250

Closed DanRStevens closed 5 years ago

DanRStevens commented 5 years ago

Seems I wrote a bug into GetDirectory when I (unconditionally) added the trailing "/". I also missed the test case that checks only a filename with no path component, which highlights this bug.

I believe this is the root cause of the problem from PR #243.

Brett208 commented 5 years ago

Oh cool. I'm glad that you found this.

I wrote the response on the other PR before reading this. I should have time later today (maybe tomorrow if I can't fence off the time) to test this and report back on what MSVC does.