search

OutpostUniverse / OP2Utility

C++ library for working with Outpost 2 related files and tasks.
MIT License
4 stars 0 forks source link

Add Tag type #251

Closed DanRStevens closed 5 years ago

DanRStevens commented 5 years ago

This relates to Issue closes #178.

I'm still trying out a few ideas, but I figured I should get this up now for review and for CI purposes. Done.

DanRStevens commented 5 years ago

Ok, I think I'm done playing around with this. The final commit is a bit of an experiment to compare having a full Tag class, as opposed to a simple using Tag alias. It adds a bit more code to do it that way, and the result is largely similar, though it does perhaps lead to a cleaner global namespace, and allow some additional conveniences, such as automatic conversion to std::string.

Brett208 commented 5 years ago

I added the new source code files to the VS project files so the tag test cases are running now on MSVC builds. I've tested by extracting from and creating both CLM and VOL files. No problems noticed yet.

I still need to test creating/reading bitmap files since this code affects bitmaps.

I ran into another bug in XFile that I will push before continuing testing. Bug is unrelated to the TAG code, just found it when testing.

-Brett

Brett208 commented 5 years ago

When I fixed the merge conflicts I used notepad++ instead of VS, so probably my fault on the spacing.