search

OutpostUniverse / OP2Utility

C++ library for working with Outpost 2 related files and tasks.
MIT License
4 stars 0 forks source link

Remove using Palette8Bit #258

Closed Brett208 closed 3 years ago

Brett208 commented 5 years ago

To ease reading, we are currently using the following type:

using Palette8Bit = std::array<Color, 256>;

It facilitates a little easier reading of the ArtFile because we do not have to dynamically resize the palette for each read.

Since Bitmaps could have other sized palettes, I think we should consider removing the type and just using a std::vector to represent the palette. This will take a bit more work to read/write from and ArtFile, but I think will facilitate easier transfer to a normal bitmap file.

DanRStevens commented 5 years ago

I think you may be right.

Brett208 commented 3 years ago

using Palette8Bit was moved out of Color.h (generic bitmap code) and into PaletteHeader.h (specific to Outpost 2 sprite loading). I think this is acceptable to close this issue.