OutpostUniverse / OP2Utility

C++ library for working with Outpost 2 related files and tasks.
MIT License
4 stars 0 forks source link

Cleanup stream method guards #287

Closed DanRStevens closed 5 years ago

DanRStevens commented 5 years ago

Updates for Write stream method guards.

This consolidates the std::vector and std::string variants of the write methods into unified container write methods. The differences were little more than variable names, and the overload type.

This relates to Issue #278. This simplifies template parameters, which may help PR #281.

Corresponding updates should be made to the Read stream method guards. (Added in PR #288).

The existing unit tests helped with the development of this. Particularly after I changed the meaning of a template T parameter, but forgot to update a corresponding sizeof(T). Nevertheless, I find myself thinking a few additional unit tests might be good, which runs through various categories of types, doing a quick round trip serialization on them.