search

OutpostUniverse / OP2Utility

C++ library for working with Outpost 2 related files and tasks.
MIT License
4 stars 0 forks source link

Write files in new directories #297

Closed Brett208 closed 5 years ago

Brett208 commented 5 years ago

I think there is an issue with XFile::GetDirectory

It returns the filename without the extension in some cases instead of the directory.

DanRStevens commented 5 years ago

The new tests should probably clean up the temporary files they are generating.

Brett208 commented 5 years ago

@DanRStevens would you be willing to help resolve the package install issues going on with the travis-ci tests?

Thanks, Brett

DanRStevens commented 5 years ago

I'm checking into the TravisCI stuff.

DanRStevens commented 5 years ago

Should we re-purpose the CanOpenNew flag with this new meaning, or should we add a new flag to allow automatic directory creation? I don't mind using the CanOpenNew flag to guard this behaviour, as it would seem odd to create new directories if creating new files wasn't allowed. Though it seems conceivable that someone might want to allow creating new files, but not allow creating new directories.

I may be overthinking this though.

Brett208 commented 5 years ago

I'm happy with the existing flag structure although I wouldn't oppose the new addition if you thought it was important.

Brett208 commented 5 years ago

@DanRStevens are you okay if I merge this branch into master now.

Thanks, Brett