search

OutpostUniverse / op2ext

Outpost 2 extension module loader
1 stars 0 forks source link

Load VOL files from INI module folders #227

Closed DanRStevens closed 4 years ago

DanRStevens commented 4 years ago

This closes #147.

I would like to add a test for the new IniModule::Directory() method. In particular, I want to verify there is a trailing slash (which I manually verified). However, the IniModule class tries to load a DLL from the constructor, and throws an exception if it fails. As we are not including an INI module for use in unit testing, this puts testing of IniModule methods outside the current scope of unit testing. Only module load failure conditions are currently unit testable. For method functions, we would either need to add testing elsewhere, or rework the class so it can be instantiated without a corresponding DLL.

DanRStevens commented 4 years ago

I just retested this now that PR #230 has been merged. It seems to work correctly. I loaded an INI module with a packaged VOL file, and found the contents do override the built in settings.