I was thinking the std::size_t size parameter should be more closely and consistently paired with the std::uintptr_t destBaseAddr parameter that it corresponds to. The variable data parameter can perhaps be moved last.
Most methods take the same first parameter std::uintptr_t destBaseAddr:
There is however an inconsistency to the name for the Op2RelinkCall method. Perhaps this should be made to match? Or is the function specific enough that it should have a more specific parameter name? Another option might be to add documentation just before the function implementation in the .cpp file.
I noticed the parameter order for theses methods seems oddly inconsistent:
I was thinking the
std::size_t size
parameter should be more closely and consistently paired with thestd::uintptr_t destBaseAddr
parameter that it corresponds to. The variable data parameter can perhaps be moved last.Most methods take the same first parameter
std::uintptr_t destBaseAddr
:There is however an inconsistency to the name for the
Op2RelinkCall
method. Perhaps this should be made to match? Or is the function specific enough that it should have a more specific parameter name? Another option might be to add documentation just before the function implementation in the .cpp file.