search

OutsideIT / FireMotD

:fire: Fire Framework Linux MoTD Generator :fire:
https://outsideit.net/firemotd
GNU General Public License v3.0
174 stars 45 forks source link

Shell Checker #27

Closed willemdh closed 7 years ago

willemdh commented 7 years ago

Shell Checker is not so happy with some of my commands. I'm planning a major rework, so I'm not getting shellcheck errors.

https://www.shellcheck.net/

@ThomDietrich Could you please test if the apt related changes are not giving any issues (as I'm not using apt)

I still need to verify on SUSE.

ThomDietrich commented 7 years ago

Hey @willemdh, I've tested the one change and it's working just as expected. I've pulled the newest revision and everything looks fine.

Btw. just realized that there is an invader theme. You need to add it to the "--help" output.

willemdh commented 7 years ago

$ shellcheck myscript No issues detected!

Finally finished the Shellcheck cleanup.

@ThomDietrich @tavinus @dimon222 Could you guys please check if I missed the ball somewhere as I did many small changes to solve all the shellcheck issues. Tx!!

ThomDietrich commented 7 years ago

Great to hear. It's hard to look at the changes across 20 "Spellcheck" commits. Should have squashed these ;) I've pulled the latest revision and everything looks good. One exception:

grafik

ThomDietrich commented 7 years ago

Found another bug.

grafik

Solution: Here https://github.com/willemdh/FireMotD/blob/master/FireMotD#L207-L208 the dot is not needed.

$ echo "${Rasp//*: /}"
Raspberry Pi 3 Model B Rev 1.2
willemdh commented 7 years ago

@ThomDietrich Thanks for testing. Did an update, it should be fixed now.

ThomDietrich commented 7 years ago

The Platform bug is fixed, thanks! The alignment bug is now down to 2 missing "#" 😄 May be related to the fact, that my hostname is a bit longer (16 characters)

willemdh commented 7 years ago

Thought I created a system one day which calculated the length of the hostname, there will be some bug somewhere, but I'll have no time anymore this week.

willemdh commented 7 years ago

I'm closing this up. i'm not really minding the # issue for now (as in fact I'm using the modern theme everywhere) but feel free to make a new isue f it bugs you. Shellchecker is finally no longer reporting any issues. :)