PHP memory_limit parsing

OutsideIT / FireMotD

:fire: Fire Framework Linux MoTD Generator :fire:

https://outsideit.net/firemotd

GNU General Public License v3.0

174 stars 45 forks source link

PHP memory_limit parsing #28

Closed ThomDietrich closed 7 years ago

ThomDietrich commented 7 years ago

grafik

On my system the memory limit can not be parsed. Reasons:

php.ini is in a different location
memory_limit is set to "-1" meaning unlimited

I can add the yet other path and I could translate "-1" to "(unlimited)". Another solution would be hiding of this part. Which would you prefer?

dimon222 commented 7 years ago

What location do u have for php.ini and is your php part of some package?

ThomDietrich commented 7 years ago

/etc/php5/cli/php.ini and no, normal package installation

dimon222 commented 7 years ago

I see, CLI is the one that used by terminal when you call "php" app there, but the one that is referenced in firemotd is actually used by webserver (nginx/Apache/whatever). I believe the webserver's one is supposed to be shown. Check this.

Are you sure there's no another location for php.ini on your box? "sudo find / -name php.ini"

willemdh commented 7 years ago

@ThomDietrich In time it should evolve to a system where the MotD is generated from a configuration file. I'm still thinking about the best way to achieve this. First thing on my to do is cleaning up the code and making sure Shell Checker has no more complaints, see https://github.com/willemdh/FireMotD/issues/27

For now I think the easiest workaround might be to hide the memory limit when it's empty.