search

OutsideIT / FireMotD

:fire: Fire Framework Linux MoTD Generator :fire:
https://outsideit.net/firemotd
GNU General Public License v3.0
174 stars 45 forks source link

Optional skip for package update (only for apt currently) #69

Closed dimon222 closed 7 years ago

dimon222 commented 7 years ago

Basically #18. Only added support for apt. Might require some testing from @ThomDietrich

ThomDietrich commented 7 years ago

Hey @dimon222, I've tested both options and they seem to work great! Thanks for that 👍

I'm not sure if "skipupdate" is a clearly understandable. Maybe you could add a better description. I also thing "-SUPD" is highly unusual. Short parameters are almost always single letters. In special cases like this it'S also common to only provide a long parameter name. How about -s or -su and skiprepoupdate? Best!

dimon222 commented 7 years ago

Yeah, I thought same about naming, but didn't find better option. -s is already used by saveupdates due to its case insensitive behavior: image

-su would be confusing since people already expect su to be superuser related.
I'm good with long name as -skiprepoupdate but still think there might be better name for short alias.

How about -sru?

ThomDietrich commented 7 years ago

Still think it's unusual but okay, -sru would be fine with me.

In the usage printout you used "-SRU", are you going to replace it? How about "Skip update for package list" -> "Skip the repository package update during update count calculation (apt only)"

dimon222 commented 7 years ago

It's following the same case insensitive pattern, but sure I can make it lowercase -sru. Also, I'm good on description update.

ThomDietrich commented 7 years ago

Wonderful. Then there is one last detail. My request originated out of the idea to issue the update right after an apt action. I believe you can add your new parameter to the README part regarding DPkg::Post-Invoke.

dimon222 commented 7 years ago

Should be done. I will run couple of tests later today to confirm that everything is ok.

dimon222 commented 7 years ago

Alright, merging.