search

OutsideIT / FireMotD

:fire: Fire Framework Linux MoTD Generator :fire:
https://outsideit.net/firemotd
GNU General Public License v3.0
174 stars 45 forks source link

First step towards external config files #86

Closed willemdh closed 6 years ago

willemdh commented 6 years ago

Please review this change. It's the first step in moving the json config out of the FireMotD. script. That way, we can make different config jsons and allow users to only select a few items out of the full reference. it's just a PoC for now, ideas are welcome. :)

willemdh commented 6 years ago

Did some more work. Rearanged the args, so verbose and debug work consistently now, splitup some stuff into functions and further finished the exportfile. There are less default values now when there is no /var/tmp/FireMotD.json. This means less overhead for systems without specific software and more flexibility. Feedback is welcome.

willemdh commented 6 years ago

@ThomDietrich @dimon222 Going to accept this pr tomorrow unless negative review fyi. Grtz!

ThomDietrich commented 6 years ago

A good step forward. I would anyhow recommend to divide the content of the full script at some point. I did that to the bigger project that includes FireMotD (openhabian) and it has shown great benefits.