OutsideIT / FireMotD

:fire: Fire Framework Linux MoTD Generator :fire:
https://outsideit.net/firemotd
GNU General Public License v3.0
174 stars 45 forks source link

make uninstall do not remove the cron job #95

Closed j0inty closed 6 years ago

j0inty commented 6 years ago

Issue Type

Missing command to remove the cron job file.

Bug report / Enhancement Request

Issue Detail

Expected Behavior

Actual Behavior

How to reproduce Behavior

dimon222 commented 6 years ago

Did i get it right, just a command to remove cronjob is missing from uninstall? Should be a question of one single rm statement then.

willemdh commented 6 years ago

@dimon222 Please check https://github.com/orgs/OutsideIT/teams/firemotd/discussions/4

The Makefile should be updated too, but as I'm not really using that..

willemdh commented 6 years ago

Just an fyi, the makefile will need additional changes to make it work with the new templates and themes.

Please use

curl -s https://raw.githubusercontent.com/OutsideIT/FireMotD/master/FireMotD -o ~/FireMotD && chmod 755 ~/FireMotD && sudo ~/FireMotD -I -d

to install FireMotD. I'll try to make an uninstall function too someday.

willemdh commented 6 years ago

@j0inty @dimon222 #121 should fix this and is compatible with new /usr/share/firemotd structure. Closing this, let me know if the new Makefie works for you.