search

OvalQuilter / lyrics-status

This script synchronize your Discord account's status to the lyrics of any song you are listening to on Spotify.
GNU General Public License v2.0
31 stars 17 forks source link

added some more tags #5

Closed Twelve0001 closed 2 years ago

Twelve0001 commented 2 years ago

yes

OvalQuilter commented 2 years ago

Your solution is good and I appreciate it, but this all can be done more easily with regexp. I won't make merge, I'll credit you in next update. There's also one more problem: image So {song_name_no_remastered} will be renamed to {song_name_cropped} and it'll include both song name - other and song name (other) crop. {song_name_letters_only} will be added without changes. Thanks.

Twelve0001 commented 2 years ago

Your solution is good and I appreciate it, but this all can be done more easily with regexp. I won't make merge, I'll credit you in next update. There's also one more problem: image So {song_name_no_remastered} will be renamed to {song_name_cropped} and it'll include both song name - other and song name (other) crop. {song_name_letters_only} will be added without changes. Thanks.

I'm not surprised the way I did it was inefficient, I've never messed with strings in JS.