search

OverZealous / cdnizer

Node module for replacing local links with CDN links, includes fallbacks and customization
MIT License
52 stars 24 forks source link

Windows path.sep fix #7

Closed jzvelc closed 9 years ago

jzvelc commented 9 years ago

On Windows there is a problem because wrong path seperator is used for filepathRel (backslash).

jzvelc commented 9 years ago

This fix also passes all tests on Windows which have previously failed.

OverZealous commented 9 years ago

@jzvelc Thanks for the PR, sorry I haven't had time to look into it. I'm not sure I love the way it sets it up and then does a replacement, but it looks safe enough.

jzvelc commented 9 years ago

True this is a quickfix however I would also like to see a clean solution to this... Any ideas? It would be great if it could be fixed asap.

OverZealous commented 9 years ago

Honestly, since I don't feel like rewriting the path function just for this, I'll just use your solution.

It'll take me a little bit to get the release out today, because I have a few other issues/PRs I'd like to work in.