search

OverZealous / run-sequence

Run a series of dependent gulp tasks in order
MIT License
961 stars 56 forks source link

Error Stack Trace #92

Closed roend83 closed 7 years ago

roend83 commented 7 years ago

Outputting the stack trace on error here is causing my build output to be totally useless when there are nested run-sequence tasks. I'm getting thousands of lines of stack trace outputted. Is there an easy way to turn this off? I'd be happy to send a PR to make this configurable or off by default.

OverZealous commented 7 years ago

Hey there!

I'll be honest, that line has been modified back and forth so many times, I don't really want to change it too much. I'll look at an easy way to configure it.

Would you be OK with a global configuration, so changing it one place changes it everywhere that runSequence is used? I envision a usage like this:

var runSequence = require('run-sequence');
runSequence.configure({ showErrorStackTrace: false });

This way I could store a simple hash of configuration options and not have to deal with per-usage configuration. This would also open the door to some other options people have wanted, without making everything too complicated.

roend83 commented 7 years ago

That sounds fantastic. Would you like me to send a PR?

On Jul 24, 2017 5:26 PM, "Phil DeJarnett" notifications@github.com wrote:

Hey there!

I'll be honest, that line has been modified back and forth so many times, I don't really want to change it too much. I'll look at an easy way to configure it.

Would you be OK with a global configuration, so changing it one place changes it everywhere that runSequence is used? I envision a usage like this:

var runSequence = require('run-sequence');runSequence.configure({ showErrorStackTrace: false });

This way I could store a simple hash of configuration options and not have to deal with per-usage configuration. This would also open the door to some other options people have wanted, without making everything too complicated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OverZealous/run-sequence/issues/92#issuecomment-317559908, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL1u-Okzx0qGcZEDnszoOKjRGdWlVgfks5sRQvwgaJpZM4OUicx .

OverZealous commented 7 years ago

Nah, I know how I want to handle this, so I'll see if I can get it built tonight. I've got some other non-code things I want to make changes to at the same time.

OverZealous commented 7 years ago

OK, should be published now. Just pull down v2.1.0.

It's even a bit simpler, just do runSequence.options.showErrorStackTrace = false; to suppress those traces.