OAuth2.0 Github authentication test

[Overdrivr]

Closing #17

[DanFaudemer]

Hello Rémi,

Amazing stuff :), In this branch there is no way to logout is it normal ?

[DanFaudemer]

I am also not able to run test Error: Cannot find module './test-credentials.json'. Is this file should be put in the root folder with some credential ?

[Overdrivr]

Thanks for the feedback ! For now, I am not testing the logout, put it is quite straightforward, just need to call the req.logout(); on for instance a custom /logout route and we're good. I've opened #25 in that regard

I will clean the console.log, good catch ! I propose to use the debug npm module that allows for nice and easy logging. Let me

It is normal you're not able to run the test, I am sorry I should have edited the readme in this branch and not there https://github.com/Overdrivr/micro-ci/pull/23/commits/9968649f3de18c1679490efb6ca050c44b5c0775

Basically, there is an example.test-credentials.json file that you need to copy, rename to test-credentials.json and fill with appropriate IDs. This file is not under versionning because it contains sensitive data. I will place a copy of the file in our vault, you will juste have to paste it into the ./test/e2e/ folder

This is not ideal, I am trying to find a better way.

[Overdrivr]

Thanks for the feedback ! For now, I am not testing the logout, but it is quite straightforward, just need to call the req.logout(); on for instance a custom /logout route and we're good. I've opened #25 in that regard

I will clean the console.log, good catch ! I propose to use the debug npm module that allows for nice and easy logging. Let me know.

It is normal you're not able to run the test, I am sorry I should have edited the readme in this branch and not there https://github.com/Overdrivr/micro-ci/pull/23/commits/9968649f3de18c1679490efb6ca050c44b5c0775

Basically, there is an example.test-credentials.json file that you need to copy, rename to test-credentials.json and fill with appropriate IDs. This file is not under versionning because it contains sensitive data. I will place a copy of the file in our vault, you will juste have to paste it into the ./test/e2e/ folder

This is not ideal, I am trying to find a better way.

[Overdrivr]

I have made the appropriate changes. Let me know if it's good for you ;)

[DanFaudemer]

I don't know where it should take place but you still have this console.log here:

server.js line 19

passport.serializeUser(function(user, done) {
  console.log("Serializing User");
  console.log(Object.keys(user));
  done(null, user);
});

passport.deserializeUser(function(obj, done) {
  console.log("Deserializing User");
  console.log(Object.keys(obj));
  done(null, obj);
});

Are they useful? :)

[DanFaudemer]

Is it possible to move the conf.js file in the test/e2e fodler ? I think it will be cleaner to not have it on the root folder.

[DanFaudemer]

After this two small point it shoud be ok. I was able to run e2e test ;)

[Overdrivr]

It's all done now ;)

[DanFaudemer]

:+1: