search

Overdrivr / micro-ci

Continuous Integration for embedded platforms
0 stars 0 forks source link

Fixed da build :bomb: #57

Closed Overdrivr closed 8 years ago

Overdrivr commented 8 years ago

Also, increased test coverage on serialize and deserialize user, because of loopback issues on where filter. See https://github.com/strongloop/loopback/issues/1009 and https://github.com/strongloop/loopback/issues/2413

Overdrivr commented 8 years ago

Doesn't seems like codeship is running on pre-merged pull request, snif

DanFaudemer commented 8 years ago

Hi Remi,

I tried to log with running the node server to github and I got this error:

Error: Incomplete user informations. Missing provider.
    at Error (<anonymous>)
    at app.deserializeUser (/var/www/micro-ci/server/server.js:95:56)
    at pass (/var/www/micro-ci/node_modules/passport/lib/authenticator.js:347:9)
    at Authenticator.deserializeUser (/var/www/micro-ci/node_modules/passport/lib/authenticator.js:352:5)
    at SessionStrategy.authenticate (/var/www/micro-ci/node_modules/passport/lib/strategies/session.js:53:28)
    at attempt (/var/www/micro-ci/node_modules/passport/lib/middleware/authenticate.js:348:16)
    at authenticate (/var/www/micro-ci/node_modules/passport/lib/middleware/authenticate.js:349:7)
    at Layer.handle [as handle_request] (/var/www/micro-ci/node_modules/loopback/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/var/www/micro-ci/node_modules/loopback/node_modules/express/lib/router/index.js:312:13)
    at /var/www/micro-ci/node_modules/loopback/node_modules/express/lib/router/index.js:280:7
Overdrivr commented 8 years ago

It's all fixed now In the future, we should also put e2e tests, or at least the most essential operations like login under CI as well. I'll open a ticket

DanFaudemer commented 8 years ago

:+1: