Overdrivr / micro-ci

Continuous Integration for embedded platforms
0 stars 0 forks source link

Issue with webhook called on non-existing repo #72

Closed Overdrivr closed 8 years ago

Overdrivr commented 8 years ago

In Repository.js https://github.com/Overdrivr/micro-ci/blob/master/common/models/repository.js#L33

This line does nothing, array can be empty meaning no repository was found, yet it won't return early since the array is defined but empty. Rookie mistake.

Instead, array.length == 0 should be checked