Dawntrail Update Checklist / Tracking

[valarnin]

This issue is meant to act as a general checklist of things to test, verify, and potentially PR fixes for after the Dawntrail release.

Pull requests for Dawntrail should reference this issue for tracking purposes.

For any struct changes, be those network packet structs or memory structs, make sure to create new structs for 7.0 so as to not break CN/KR support.

• [x] Adjust for any changes in Machina
• [x] Adjust for any changes in FFXIV_ACT_Plugin.dll
• [x] Verify network packet updates for all possible packets
  • [x] Verify packet layouts - #361
  • [x] Update and verify opcodes - #361
  • Network packet code that needs to be verified lives under OverlayPlugin.Core/NetworkProcessors
  • [x] OverlayPlugin.Core/MemoryProcessors/LineCombatant.cs reads the ActorID and LoginUserID values from the packet header. Verify that these don't need adjusted.
• [x] Verify memory updates
  • [x] Verify memory struct layouts - #360
  • [x] Verify memory signatures - #359
  • Memory code that needs to be verified lives under OverlayPlugin.Core/MemoryProcessors
  • AtkStage can be ignored, as it is not currently in use

[valarnin]

I am looking into the broken signatures, currently:

All broken signatures should be fixed in #359

These errors belong to cactbot:

Error: Job signature found 0 matches
Error: In combat signature found 0 matches

[valarnin]

There are two outstanding issues:

1. Need to verify that we have the correct offset for PCTargetID in the Combatant struct
2. Need to review the getCombatants logic in its entirety and determine how to handle potential read-past-allocation-boundary issues (see Discord #beta-testing discussions)