search

OverlayPlugin / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
84 stars 34 forks source link

raidboss: ex2 timeline+triggers #216

Closed wexxlee closed 1 month ago

wexxlee commented 1 month ago

This is an initial pass at ex2. Original timeline thanks to @valarnin (this PR replaces #192), with some adjustments/cleanup from me, but I think the timeline is largely good.

Triggers have been tested against raidemulator but still need some testing in game and may need a little cleanup in some spots (marked as draft/wip for now, but I should be able to get back in tonight). There's a to-do list at the top for some mechs that do not yet have triggers. I'm going to keep poking at them tonight, but it may make sense to merge as-is and do with follow-up PRs.

wexxlee commented 1 month ago

OK, this looks good to me in testing.

@valarnin @JLGarber, let me know if you have any other comments or changes - otherwise, I think this is good to merge. There's still one TODO item for the Fiery/Stormy Edge stuff, but I'll need to carve out more time to (a) map out the right lines to use for a trigger, and (b) figure out what should be called vs. too much info, so I think a follow-up PR is fine since the rest of the fight is now complete.

Legends0 commented 1 month ago

I'll be able to check this out tonight.

Legends0 commented 1 month ago

The timeline and triggers worked well for me.