valarnin
commented
1 month ago I know that if the OP option to end encounter when out of combat is enabled, that will reset the entire raidboss module. But I don't know if there's a check for e.g. the InCombat line somewhere.
On Wed, Jul 17, 2024, 22:57 Wexx @.***> wrote:
@.**** commented on this pull request.
In ui/raidboss/data/07-dt/raid/r2n.txt https://github.com/OverlayPlugin/cactbot/pull/243#discussion_r1682031950 :
hideall "--Reset--" hideall "--sync--"
-0.0 "--Reset--" ActorControl { command: "4000000F" } window 0,100000 jump 0
I'm not 100% sure off the top of my head. I copy/pasted the timeline from the make_timeline tool initially, apparently that doesn't include the reset. If it's still required, I guess it's a bug in make_timeline too?
@JLGarber https://github.com/JLGarber - do you know whether an affirmative Reset line is still required? As for make_timeline, I'm not positive, but I suspect the reason it's not included in the default output is because it wouldn't apply, e.g., to dungeon content or other content that uses seals/unseals instead of ActorControl wipes. Still, to your point, make_timeline should be able to detect if that's the case and add it (if it is, in fact, required).
— Reply to this email directly, view it on GitHub https://github.com/OverlayPlugin/cactbot/pull/243#discussion_r1682031950, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOWBLRN2G2CGGTN5Z7NJPDZM4VLBAVCNFSM6AAAAABK7EXMO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBUGUYDCNZTG4 . You are receiving this because you authored the thread.Message ID: @.***>
I included headmarker info for future savage comparison.
Loop needs verified still.
Stack/Spread/tank lines/light party stacks might be better triggered off of headmarkers, felt like the cast ability was slightly slower than headmarker.
stacksoutputStrings value was copy/pasted from another trigger set, might be better to only include theenvalue and let translators handle the others.