search

OverlayPlugin / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
85 stars 34 forks source link

Trigger of AbilityExtra cannot obtain the heading in matches #310

Closed Souma-Sumire closed 1 month ago

Souma-Sumire commented 1 month ago

What's your question?

Hello, I have a raidboss trigger like this:

    {
      id: 'xxxx',
      type: 'AbilityExtra',
      netRegex: { 'id': '95C7' },
      run: (_data, matches) => {
        console.log(matches);
      },
    },

However, the heading attribute does not exist in matches (neither in the type hints nor in the actual object). image

whereas the log contains: [06:27:48.055] 264 108:40013385:95C7:00013ED8:1:0.000:0.000:0.000:2.356.

Is this a bug or a feature? Thank you in advance for your assistance.

wexxlee commented 1 month ago

Is this a bug or a feature? Thank you in advance for your assistance.

Bug. Looks like the same root cause as the issue I fixed in #265 - the field is defined as optional so not included in capture regex. Will PR a fix for this tomorrow.