search

OverlayPlugin / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
85 stars 34 forks source link

resources: Add the new (as of 7.0) 21/22 line fields #315

Closed xpdota closed 1 month ago

xpdota commented 1 month ago

Adds the new fields in the 7.0 version of the plugin.

From a decompile, the new fields are:

combatant?.ID ?? 0, combatant?.Name, (byte)(int)packetMessage.effectDisplayType, packetMessage.actionId, packetMessage.actionAnimationId, packetMessage.animationLockTime, packetMessage.rotation

This should fix the issues that the log anonymizer has with the new fields.

xiashtra commented 1 month ago

Can we update the index table to match the lines? It's gotten quite out of sync, and is missing several entries.

xpdota commented 1 month ago

Can we update the index table to match the lines? It's gotten quite out of sync, and is missing several entries.

Sounds good. Should I also change the first field to use the network log format instead of the parsed format?

xiashtra commented 1 month ago

Can we update the index table to match the lines? It's gotten quite out of sync, and is missing several entries.

Sounds good. Should I also change the first field to use the network log format instead of the parsed format?

I'm not sure if we have an established rule for that, but in my opinion, it should follow the network lines. Others might want to chime in.