OverlayPlugin / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
85 stars 34 forks source link

r1s: fix nailchipper quadruple crossing callouts #317

Closed jacob-keller closed 1 month ago

jacob-keller commented 1 month ago

During the Leaping Quadruple Crossing given by one of Black Cat's clones, players are hit by Nailchipper and given a headmarker which indicates that they will do a mini explosion and will die if they get hit by the next Quadruple Crossing bait. The markers always go either on all DPS or on all support players.

Currently, when this marker goes out, cactbot incorrectly calls out "stack on " for whichever player happens to be first in the data log. This could in theory be used to see who has the nailchippers and processed into a decision of whether to go in or out. However, using the term "stack" is very odd since it is not a stack mechanic.

Instead, check what role the target is. Based on this, alert either "Support out" or "DPS out".

We could complicate this further by checking the role of the player and alerting either in our out, (or some other alert such as baiting). While this could be doable its more complicated to get correct.

Signed-off-by: Jacob Keller jacob.keller@gmail.com

cactbotbot commented 1 month ago

@jacob-keller Thanks for your contribution! 🌵🚀

Currently your title is: r1s: fix nailchipper quadruple crossing callouts, but it should:

Did you mean: dps: fix nailchipper quadruple crossing callouts

More Information `scope` can be any of the following: - `build` - `ci` - `config` - `docs` - `dps` - `eureka` - `i18n` - `jobs` - `lint` - `oopsy` - `plugin` - `pullcounter` - `radar` - `raidboss` - `raidemulator` - `resources` - `test` - `type` - `util` Multiple scopes can be combined with slashes if needed, e.g. `raidboss/oopsy`. Valid Title Examples: - `i18n: translating a bunch of new stuff` - `raidboss: fix bug in New Ultimate Fight` - `plugin: update Bozja CE code for patch 6.34` - `lint: change @typescript/irritating-lint warning` - `raidboss/oopsy: support shiny new dungeon` Drafts can also use `[wip]` as a prefix to show that they are a "work in progress", e.g. `[wip] plugin: refactoring everything`. Breaking changes can use `!` as a prefix to mark a breaking change, e.g. `!plugin: change all the apis`.

This comment is created and updated by a bot.

jacob-keller commented 1 month ago

This is actually likely fixed by https://github.com/OverlayPlugin/cactbot/pull/307 sorry for the thrash, I think that solution will be better.