search

OverlayPlugin / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
97 stars 34 forks source link

raidboss: Fix issue with KR/CN compatibility #331

Closed valarnin closed 2 months ago

valarnin commented 2 months ago

Fixes #327 Fixes #328

Changed capture regex does not reference the new fields unless they're required for the trigger. If the new fields are required for a trigger to be handled, the new fields can be included as parameters with wildcard matches, but those triggers will not work for KR/CN users.

image

wexxlee commented 2 months ago

Should the same change be made to the logdef for 22 lines as well? I can't remember offhand how ParseHelper handles creating capture regex for Ability. (On mobile right now, can't check until late tonight.)

valarnin commented 2 months ago

Yeah, good catch. The impact was only a couple triggers in PotD and some oopsy stuff I believe, but best to be thorough.

MaikoTan commented 2 months ago

Glad to see it has been fixed. Should we now release a new version immediately so that CN/KR players will have this fixing patch?

wexxlee commented 2 months ago

Glad to see it has been fixed. Should we now release a new version immediately so that CN/KR players will have this fixing patch?

Makes sense to me. Feel free to version bump (or I can PR it tomorrow if no one else gets to it first.)

MaikoTan commented 2 months ago

Makes sense to me. Feel free to version bump (or I can PR it tomorrow if no one else gets to it first.)

Unfortunately I am having a trip without a PC ⊙⁠﹏⁠⊙