search

OverlayPlugin / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
85 stars 34 forks source link

raidboss: fix misused IN in R4S #346

Closed Echoring closed 1 month ago

Echoring commented 1 month ago

Response getIn refers to dodge a donut-like AOE, not a side cleave. https://github.com/OverlayPlugin/cactbot/blob/0b794d021c1acc8d6dbe0b067e8dc9ade3bbff47/resources/responses.ts#L434-L435 It is ambiguous here, and goMiddle response seems better suit this situation.

Also fix an i18n issue. Has been fixed by other.