search

OverlayPlugin / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
97 stars 34 forks source link

raidboss: r4s sunrise sabbath fix #366

Closed wexxlee closed 2 months ago

wexxlee commented 2 months ago

Fixes #361.

The issue occurs because in some (but apparently not all) logs, the ActorSetPos and ActorControlExtra packets that are needed to identify the jumping clone and its position are ordered differently. Adding a short delay to R4S Sunrise Sabbath Jumping Clone Collect 1 (to ensure the related ActorSetPos collector processes first) seems to fix the issue -- and because both collectors happen ~3s before the cannon color collect and subsequent callout trigger, this added delay doesn't delay the mechanic callout at all.

This fixes the issue in the log @valarnin passed along, but additional in-game validation couldn't hurt.

jacob-keller commented 2 months ago

This seems reasonable. I can't test it yet because my group isn't at m4s.

wexxlee commented 2 months ago

Going to merge this for now given the need to version bump - if it doesn't resolve the issue, we can revisit.