OverlordsIII / VillagerNames

A mod that adds names to villagers and golems
https://www.curseforge.com/minecraft/mc-mods/villager-names-for-fabric/
Creative Commons Zero v1.0 Universal
8 stars 8 forks source link

[Bug] child villager gets profession name as family name #29

Closed LeoK77S closed 2 years ago

LeoK77S commented 2 years ago

server game version: 1.18.1 fabricloader: 0.12.12 fabric api: 0.44.0+1.18 mod version: 2.0.2

In the first image, one child villager named "Ediltrudis the Fisherman", the reason is his parents are all "Fisherman". Perhaps when one of his parent is "Fisherman" will also get the same name like "XXX the Fisherman", I didn't test this. So I guess for this "Ediltrudis the Fisherman", "the Fisherman" is his family name he got from his parents, but unfortunately is used the profession name and with a "the" in front. And some child villagers get a name like "Linda the", which also shows in the first image. In the second image, it shows a villager named "Lohrman the". And I think when he was a child, his name is "Lohrman the Fisherman" or just "Lohrman the". In the third image, when these villagers get profession, the name becomes weird, like "Astride the the Toolsmith".

All the villagers borned by parents who had profession seems have this problem, they get "the profession" or "the" as their family name when they are children and "the" as their family name when grow up.

child villager

villager without profession

villager with profession

OverlordsIII commented 2 years ago

Should be fixed in the latest version, could you check to see if it works?

LeoK77S commented 2 years ago

It works! Thanks!